-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15905] Fix dataraces when creating DataWriters #3008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, but we should add a test
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
…ace regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
00a4a04
to
4987408
Compare
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@richiprosima Please test this |
@richiprosima Please test mac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/Mergifyio backport 2.7.x 2.6.x 2.3.x 2.1.x |
* Refs #15905: Declare the PublishMode running flag as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add RTPS regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add DomainParticipantImpl::create_instance_handle data race regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Set DomainParticipantImpl::next_instance_id_ as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 4391864)
* Refs #15905: Declare the PublishMode running flag as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add RTPS regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add DomainParticipantImpl::create_instance_handle data race regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Set DomainParticipantImpl::next_instance_id_ as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 4391864)
* Refs #15905: Declare the PublishMode running flag as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add RTPS regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add DomainParticipantImpl::create_instance_handle data race regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Set DomainParticipantImpl::next_instance_id_ as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 4391864) # Conflicts: # src/cpp/rtps/flowcontrol/FlowControllerImpl.hpp # test/blackbox/common/DDSBlackboxTestsBasic.cpp # test/blackbox/common/RTPSBlackboxTestsBasic.cpp
✅ Backports have been created
|
* Refs #15905: Declare the PublishMode running flag as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add RTPS regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Add DomainParticipantImpl::create_instance_handle data race regression test Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Set DomainParticipantImpl::next_instance_id_ as atomic Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #15905: Apply suggestions Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit 4391864)
Signed-off-by: Eduardo Ponz eduardoponz@eprosima.com
Description
This PR fixes a segmentation fault that may arise when calling
RTPSParticipantImpl::createWriter
on the same participants in parallel from different threads.@Mergifyio backport 2.7.x 2.6.x 2.3.x 2.1.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist